ADVERTISEMENT

Eremko

Hey, thank you so much for helping out on the mesmer trait line tooltips. You have no idea how much each bit helps us out in the long run :) Thanks! « Chase ♥ ♥ ♥ » 14:01, 11 September 2014 (UTC)

Great job on the mesmer traits, thanks for helping out!--Galaxian (talk) 19:13, 11 September 2014 (UTC)
You are welcome guys, I'm glad I could help. These tooltips makes this site even better, thank you for your hard work! By the way - I used 24px for "desc-det" icons in tooltips, I think it looks much better than 32px, what do you think? Aaand one more thing - I'll start working on thief traits now and tomorrow :) --Eremko (talk) 19:43, 11 September 2014 (UTC)
I didn't even notice the 24px modification but it does actually look better than 32px. Also, don't forget to edit the first line <div class="Hexagon-Trait Traits-Profession-Master mbhi"> where it says "Master" when editing the templates.--Galaxian (talk) 19:59, 11 September 2014 (UTC)
24 does look better. I was using 32 because we can fit two lines on there once I do a quick CSS trick. I am unsure if we can do it both ways. With a 24 we could probably add padding perhaps. let me see if I can do the trick real quick, shouldn't be more than one line. « Chase ♥ ♥ ♥ » 21:29, 11 September 2014 (UTC)
Okay, I fixed it so you can see why 32 is what I was planning to do. It is more inline with what the game actually uses. I'm sorry I didn't implement this in earlier, but it should make sense now. Go to mesmer, 2nd line, XII, furious something (labelled wrong on tooltip) you can see the quickness icon at 24 and the two line description looks weird. But if you change it to 32 it looks much better with the two lines reading top to bottom of the icon properly. Normally the words are somewhat centered on teh icon which is okay too. So I'm afraid we'll have to change the icons back to 32px, sorry! « Chase ♥ ♥ ♥ » 21:42, 11 September 2014 (UTC)
No problem, I'll change mesmer icons back to 32 and will do the same on the thief tooltips I'm currently working on, it does look better after you CSS changes. I would although try to add 1px padding to the right of the icon. Might look slightly better. Also can you please check mesmer, 1st minor trait in first line? I used sub html element to indicate number of stacks and it does not work very well after the CSS change. Maybe you could come up with something better to indicate boon/condition stacks? --Eremko (talk) 21:50, 11 September 2014 (UTC)
I changed the padding as you were typing I think. So that should be good (Set to 5px to match left padding of icon to box). I loved the sub idea, was going to work on it later, but you kinda forced me to do it now xP I made it green so it's easier to read. There is a slight complication that it will always display in teh same location. So for Mesmer, line 3, trait 13 you'll want to add a class to make it appear on the second icon as such: <sub class="icon-2">9,000</sub> The numbers should always appear right-aligned even if it's double-digit, so I think it will be quite uniform and I've tested it against multiple lines. But I could have made a mistake, who knows. Let me know if you have any more problems and definitely keep the ideas coming :) « Chase ♥ ♥ ♥ » 22:11, 11 September 2014 (UTC)
The sub CSS changes are great man! If you can, try to do following changes, looks slightly better (just in Opera 12, in Chrome it looks different): "sub { left: 16px; top: 0px; } sub.icon-2 { left: 48px; top: 3px; }". Also when these traits are inside of table, there is large padding between lines / icons. Check e.g. Mesmer 3/VII and 3/VIII, there are huge spaces in between lines - can you please try to somehow fix it in the CSS? Probably adding !important notation to the padding hover? Thanks. --Eremko (talk) 9:48, 12 September 2014 (UTC)
Hm, I'm not able to reproduce your problem on Chrome. I will download on Opera 12 to see what's up :) « Chase ♥ ♥ ♥ » 14:23, 12 September 2014 (UTC)

Admin position[edit]

Hey, sorry about the late reply, I managed to miss your comment somehow :( I will gladly make you an admin, is that something that you are still interested in?--Galaxian (talk) 21:48, 16 September 2014 (UTC)

Sure, I have all trait templates on my watchlist anyway, I'll make sure they stay correct and up-to-date with the patchnotes :) Also let me guys know when you have skill templates ready, I'll prepare more wiki parsers for skills and we can get everything done easier that way. --Eremko (talk) 13:50, 19 September 2014 (UTC)
Alright great, you are template admin from now on ;) Add your contact info here please: http://metabattle.com/wiki/MetaBattle:Administrators--Galaxian (talk) 19:35, 19 September 2014 (UTC)

Next Tooltips[edit]

So we've got the traits under directory Trait/Profession/Line#/MajorAndMinorTraits, and we can start the skills as Skill/Profession/Name. How do you think we should handle cross-profession skills, like evading? I thought we could do Skill/Evade, which skips the profession subdirectory. But we can create a "Common" subdirectory too. Let me know your thoughts on this.

Secondly, items like Sigils, Runes, and Food. Perhaps like Item/Rune/Scholar's will display the 6/6 bonuses on an icon as default, we can always add a parameter to display less than that. Item/Sigil/Bloodlust would be Superior Sigil of Bloodlust, I cannot imagine we'll be using less than superior, but if we were, then again, as a parameter I think would be fine like {{Item/Sigil/Bloodlust|mms=Minor}} or something.

There are some specialty builds that might use Gems/Talismans/Marks or something, but we can ignore that for now. Just keep it in mind perhaps for later.

Gear seems to be very time-consuming. There are lots of stat options, ranging from weapon/armor/trinket type (16+6+6), the quality like exotic vs ascended (2), and the type of stat like berserker's, rabid, etc (20+ if we do them all). Obviously that's a lot, lot, lot of combinations. What do you think would be best for this scenario? We could ignore the actual stat numbers and just display the stat spread; for instance berserker's -- POWER, Precision, Ferocity, or Assassin's -- PRECISION, Power, Ferocity. We could also try a double template system? Where the numbers for all stats are set in one template, and is called from the individual weapon templates with the stat spread being pulled from a third template. There are options here, and it seems this is probably the hardest one to complete.

PvP Amulets on the other hand should be pretty easy to do. Also Skills, Sigils, and Runes with your parser might be pretty easy too. Let's just figure out the directory and possibly and other information like variables/parameters we might have to incorporate. I'll write up a "template" then if you'd like, or if you wanna take the lead on this that's cool too. And again there is no rush on this, I'm posting it early just to get the ball rolling :) « Chase ♥ ♥ ♥ » 14:44, 23 September 2014 (UTC)

If you're at it, could you look into why the new traits mess up the pages if they have a " * " before them? So for example if you are listing trait variants. --Necromancer Icon Color.pngHanz(talk) 20:01, 23 September 2014 (UTC)
I don't think I can fix that. Mediawiki inserts extra code after the page is complete. We might however be able to add a parameter to the first trait variant so that it begins with a bullet point. Another idea is adding a "variants" template which makes all variants look nice, might look into that method « Chase ♥ ♥ ♥ » 11:52, 24 September 2014 (UTC)
Chase, what do you mean by cross-profession skills? I don't think there is such a thing - template for skill should look pretty similar to template for trait, it basically consists of 6 things: %SKILL_NAME%, %RECHARGE%, %DESCRIPTION%, %EFFECT_LINES% (we all had these in trait templates), now we have two more things: %ACTIVATION% and %SKILL_TYPE% (e.g. Manipulation, Shout, Consecration, etc.) - that's just an text in different color before the description. Regarding the directory structure - in traits, it kinda made sense to have it like Trait/%PROFESSION%/%LINE_NUMBER%/%MAJOR_NUMBER_MINOR_NAME%, but I think we can skip %PROFESSION% subdir for skills, what do you think? We could just have it like: "Skill/%NAME%". There are not so much duplicate skill names, but sure - there are some, but there are also duplicates for same profession (for example thief has two skills of the same name - one on shortbow and one on harpoon gun = Disabling Shot) so making it Skill/Profession/ would not help. I would do it like this - when there are skills with duplicate name, we should select one as main (one is always more common, e.g. that one on short bow) and made that one as main "Skill/Disabling Shot" and for the duplicates we should create another subdir like "Skill/Disabling Shot/2", I think there will be like 5-10 tops and we can list those exceptions somewhere. So my suggestion for skills structure is simply "Template:Skill/%NAME%". If you could prepare one sample template for single skill, it would be great - I will then take that and prepare helper scripts to help us fill these. After than, we can do the same for Items/Runes, but let's focus on skills now :) Together with skills, we also could (should) create weapon templates like "Template:Weapon/%PROFESSION%/%MH/%OH", e.g. "Weapon/Mesmer/Sword/Pistol" or "Weapon/Warrior/Greatsword". -Eremko (talk) 14:26, 25 September 2014 (UTC)
Okay agreed, let's try SKILL/NAME. How will we decide which skills are more common? Should we just go with what the wiki has designated? Obviously we can display whatever we'd like on the tooltip so it's no big deal. Will start working on a sample template now. « Chase ♥ ♥ ♥ » 14:50, 25 September 2014 (UTC)
New idea, how about we always distinguish the skills and create a separate template for "switching" between the two. So we have SKILL/DISABLING SHOT (SHORTBOW) and SKILL/DISABLING SHOT (HARPOON GUN) and the template SKILL/DISABLING SHOT will require a parameter like {{Skill/Disabling Shot|type=Shortbow}} and if no parameter is given it pastes the text "Please use 'type' parameter to distinguish between 'Shortbow' or 'Harpoon Gun'. See [link] for usage information.". I'm saying this only because there will undoubtedly be a time when people try to post other skills like inline text or somethign and will be confused how to use it. Do you think this is too much or will it be effective? « Chase ♥ ♥ ♥ » 15:01, 25 September 2014 (UTC)
That's a good idea, let's do that :) --Eremko (talk) 23:38, 25 September 2014 (UTC)
Also by cross profession i meant like "evade" or "drop bundle" or "swap weapons"; skills that more than one profession can do. « Chase ♥ ♥ ♥ » 15:01, 25 September 2014 (UTC)
Seems to be basically the same as last time, I can't think of any other differences besides some "gold text" that we might need on some and changing the default size of icons to 52px to match ingame sizes for skills. Afraid the really hard stuff is up to you. I will try to re-do the icons on our server to closer match what's in game (less egregious blank borders). Also there is a template example that I worked on quite a while ago already up. Notice the variable for bountiful theft in the desc-det, these kinds of things are not required on first pass, we can probably work on those wayyyyyy later. Also let's not use SKILLS for the directory, i like SKILL without the "s" at the end. Fits with the TRAIT directory idea too.
 %NAME% what we see on the tooltip in game, e.g. "Disabling Shot"
 %WIKINAME% what it's called on the wiki, e.g. "Disabling Shot (thief shortbow skill)", might be same as %NAME%. Used for links to the wiki page and for the icon from our servers (which I think follow this convention).
Not sure how you want to handle the title-details section for recharge, activation, and initiative cost
Not sure how you want to handle the gold writing portion on some skills (like "Dual wield." on some thief skills), but they have %GOLDWRITING% and %DESCRIPTION% if you wanna use that lol
Not sure how you want to handle the desc-det section for damage, stun, range, etc.
<div class="mbhi">
    {{#if: {{{size|}}} | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div> | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|22px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|52px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div>}}
    <div class="mbinfo">
        <div class="mbinfo-main">
            <div class="title">
                <div class="title-details">
                    <div><span>{{#if: {{{cd|}}} | {{{cd}}} | 15}}</span>[[File:Recharge.png|14px|14px]]</div>
                    <div><span>{{#if: {{{at|}}} | {{{at}}} | ¾}}</span>[[File:Activation.png|14px|14px]]</div>
                    <div><span>6</span>[[File:Initiative-Cost.png|14px|14px]]</div>
                </div>
                <div class="title-name">%NAME%</div>
                <div class="clear"></div>
            </div>
            <div class="clear"></div>
            <div class="desc"><span class="gold">%GOLDWRITING%</span> %DESCRIPTION%
                <div class="desc-det">
                    <div>[[File:Damage.png|32px|32px]]<span data-type="damage">Damage (9x): 1,062</span></div>
                    <div>[[File:Stun.png|32px|32px]]<span data-type="stun">Stun (1/2 sec): Unable to use skills or move.</span></div>
                    <div>[[File:Range.png|32px|32px]]<span data-type="range">Range: 130</span></div>
                </div>
            </div>
        </div>
        <div class="mbinfo-ext">

        </div>
    </div>
</div>
Feel free to double check it for errors ^_^ « Chase ♥ ♥ ♥ » 15:41, 25 September 2014 (UTC)
Ok, this looks good. I'll prepare the scripts soon, hopefully this weekend. In the meanwhile, what will we do with gw2skill and gw2trait templates? We should get rid of those and use new Trait/... and Skill/... templates instead for both large and small icons (small with |label=1 parameter set). We could easily automate this for gw2skill but moving gw2trait would be pretty painful since the "old" gw2trait used only 2 parameters - ID and NAME but we now need TRAIT_LINE_ID, ID and PROFESSION instead. --Eremko (talk) 23:40, 25 September 2014 (UTC)
Yay, MediaWiki API batch page editor done, skill parser about 90% done. Brace yourself, all skill tooltips v1.0 incoming in few hours :) --Eremko (talk) 13:41, 26 September 2014 (UTC)
That is insanely fast work, Eremko! Honestly, those skills are a life-saver! So I'm messing around with the "bug" you found. It happens to be something to do with mediawiki itself. It will create UL tags around the template, however it only keeps the first part the "hoveron" and then the actual mbhi or something gets pulled out of this div. I'm wondering if we wrap the whole thing better, maybe we can avoid this problem. Will continue working on it. However, I was not able to get the skills template to work in a ul either, could you re-create that for me? I tried this:
 
testing

* asdf {{Skill/Steal|label=1}} asdf


* asdf {{Trait/Mesmer/1/V|label=1}}asdf
and it totally destroyed the page by closing divs that were opened for the main page css etc « Chase ♥ ♥ ♥ » 13:55, 26 September 2014 (UTC)
Strange, that's exactly what I used on your talk page and it worked for skill template but it didn't work for trait template (empty line there). I believe in you, you can do it! :D If possible, it would be great to do it without changing existing trait templates (but not necessarily since I'm able to perform some automatic batch updates now). --Eremko (talk) 14:15, 26 September 2014 (UTC)

Runes/Sigils[edit]

Let's base these on the PvP versions for reference. I'm advocating to keep the duplicate icon in the tooltip (in case we display text only version) and to remove the blank space above the icon/title. For some sigils I think it'd actually be really nice to show the cooldown in the title details that we usually have. What do you think about that?

Runes

Do we care about tier? Minor, Major, Superior? I'm assuming not, since we're so end-game / pvp focused. That's why I removed the "superior" and left it as it is in PvP. However, we can do something like {{ifeq: {{{tier|}}} | Minor | Then | Else}} You can see an example on my sandbox. Note the variable name of the rune in title-name is a diff variable (sans "Superior") if you agree. There are some Bonuses that have cooldowns written in grey. I don't know which one's are with cooldowns or how you will handle that, but I have written the variable for 4 and 6 in correctly. I don't know how this comment new line thing works, but it was required for the span elements to show up properly. « Chase ♥ ♥ ♥ » 17:11, 1 October 2014 (UTC)

<div class="mbhi">
    {{#if: {{{size|}}} | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div> | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|22px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|52px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div>}}
    <div class="mbinfo">
        <div class="mbinfo-main">
            <div class="title">
                <div class="title-details">
                </div>
                <div class="title-name">[[File:%WIKINAME%.png|32px|link=]]<span class="runesigil">%RUNENAME%</span></div>
                <div class="clear"></div>
            </div>
            <div class="clear"></div>
            <div class="desc">
                <div class="desc-det"><!--
-->                    <span class="noma"><span class="magic">(1): %BONUS1%</span></span><!--
-->                    <span class="noma"><span class="magic">(2): %BONUS2%</span></span><!--
-->                    <span class="noma"><span class="magic">(3): %BONUS3%</span></span><!--
-->                    <span class="noma"><span class="magic">(4): %BONUS4%</span> %BONUS4CD%</span><!--
-->                    <span class="noma"><span class="magic">(5): %BONUS5%</span></span><!--
-->                    <span class="noma"><span class="magic">(6): %BONUS6%</span> %BONUS6CD%</span>
                </div>
            </div>
        </div>
        <div class="mbinfo-ext">

        </div>
    </div>
</div>

Sigils This one also has interesting set up structure for the details. I don't know how you want to do that, but the rest is correct I believe. Set the default size to 30px to match in game. It will look really nice in our template when we get around to that ;) « Chase ♥ ♥ ♥ » 17:52, 1 October 2014 (UTC)

<div class="mbhi">
    {{#if: {{{size|}}} | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|{{{size}}}px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div> | <div class="mbhoveron">{{#if: {{{textonly|}}} | <span class="label">%NAME%</span> | {{#if: {{{label|}}} | [[File:%WIKINAME%.png|22px|link=gw2:%WIKINAME%|%NAME%]] <span class="label">%NAME%</span> | [[File:%WIKINAME%.png|30px|link=gw2:%WIKINAME%|%NAME%]] }} }}</div>}}
    <div class="mbinfo">
        <div class="mbinfo-main">
            <div class="title">
                <div class="title-details">
                </div>
                <div class="title-name">[[File:%WIKINAME%.png|32px|link=]]<span class="runesigil">%RUNENAME%</span></div>
                <div class="clear"></div>
            </div>
            <div class="clear"></div>
            <div class="desc">
                <div class="desc-det"><!--
-->                    <span class="noma"><span class="magic"></span></span><!--
-->                    <span class="noma"><span class="magic"></span></span>
                </div>
            </div>
        </div>
        <div class="mbinfo-ext">

        </div>
    </div>
</div>

Gw2skill template[edit]

Great job with the skill templates, it looks beautiful! There is just a small problem, sigils, runes and boons are using the same template which doesn't work atm, example: http://metabattle.com/wiki/Build:Elementalist_-_Dagger/Dagger -- Galaxian (talk) 15:34, 30 September 2014 (UTC)

Hey, I know, I'm still working on it, I'm currently solving issue with "conflicting" skill templates (e.g. Ring of Fire), these should work without changing anything (you should not have to define the type parameter). Regarding sigils, runes, food - this is something people creating the builds actually screwed up because they should used gw2sigil, gw2rune, gw2food templates (which already existed like 3 months ago) :( I think people will just have to fix their build pages. --Eremko (talk) 15:40, 30 September 2014 (UTC)
It's not only about the wrong templates. PvP Equipment, every sigil and rune in the PvE/WvW equipments, they are all broken atm. --Necromancer Icon Color.pngHanz(talk) 15:59, 30 September 2014 (UTC)
Well as I said, people used wrong template when they created the build. Instead of criticism me you can just go there and fix the guides. E.g. gw2rune instead of gw2skill. --Eremko (talk) 16:02, 30 September 2014 (UTC)
I'm not criticizing anyone, you did an awesome job! :D I'm just saying that it's not only about gw2skill/gw2sigil and thing like that, but also about the Equipment part in general - for example if you look at any build, none of the runes or sigils work on weapons / armors and those parts were done correctly everywhere. Edit: you've already fixed this. Sry senpai. :P--Necromancer Icon Color.pngHanz(talk) 16:10, 30 September 2014 (UTC)
Well I temporarily disabled tooltips in these "small" iconic templates and I will focus on "large" (SkillBar, HUE, SwapWeap) iconic tooltips. We'll have to fix all guides to use correct templates before changing gw2skill template. I could probably write an script to fix the templates automagically. But I'm really exhausted now :P you can't imagine how much I work put into these skill tooltips (901 skill templates and 640 trait templates, partially generated automatically but all verified and polished by myself). --Eremko (talk) 16:16, 30 September 2014 (UTC)
You deserve some rest :P I'll look into the sigil/rune part but I'm not sure if there's a template for boons and conditions. --Necromancer Icon Color.pngHanz(talk) 16:22, 30 September 2014 (UTC)
Yeah, we currently don't have one for those. We can leave that in gw2skill now I guess. --Eremko (talk) 16:25, 30 September 2014 (UTC)
Good news everyone. I created new template Exists and then I edited gw2skill template using this and I've created a fallback. So this basically means we don't have to go and fix the guides - when something is passed into gw2skill template what is not skill (condition, food, ...) it automatically handles it using the fallback. TL;DR - it works automagically. --Eremko (talk) 17:03, 30 September 2014 (UTC)

Found a mistake[edit]

I uh....think I made a dumb error in the past. When our mbhi is used inline we apply a style="display:inline;" it is actually supposed to be style="display:inline-block" i think. Do you think it would be possible to change those? I'll see if I can find an example. With inline it leaves an inherent space afterwards so any closing parentheses, commas, periods, or other punctuation right after the mbhi would always have a space before it. If it's changed to inline-block it becomes normal, not sure why that is. « Chase ♥ ♥ ♥ » 01:30, 18 November 2014 (UTC)

Hey, sure. I could make an batch to change it everywhere if you are sure about it :) --Eremko (talk) 23:57, 18 September 2014 (UTC)
Yeah I can't even seem to find out where the mbhi gets it's "display: inline;" from! I went through an individual template design and I checked the gw2skill template too to possibly see where it's coming from. if you know where the change is to be made, a safe bet would probably be to remove the style tag from the element and add another class to it like "mbhi-in-text" so that we can change the CSS for all of them (just in case I am wrong I don't want to have you try to fix all this again xP). « Chase ♥ ♥ ♥ » 14:39, 19 November 2014 (UTC)
ADVERTISEMENT
ADVERTISEMENT